This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
[REFACTOR] Restructure records iterator #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nericExportMixing and extend DatasetIterator with the mixin
burtenshaw
approved these changes
May 13, 2024
burtenshaw
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reviews the records iterator + export and moves all the export-related logic to the mixin. With that change, we don't need an extra class to combine iterator + export.
Also, the
DatasetRecordis not aResourceanymore. Still using theself.logby using theLoggingMixinclass