Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

[DOCS] update docs snippets for suggestions ingestion #175

Merged
merged 3 commits into from
May 14, 2024

Conversation

burtenshaw
Copy link
Contributor

This PR closes #160

By updating the snippet to conform with functionality:

dataset.records.add(
    [
        {
            "text": "Hello World, how are you?",
            "label": "negative",
            "label.suggestion.response": "negative",
            "label.suggestion.score": 0.9,
        },
    ]
)

@burtenshaw burtenshaw changed the title docs: update docs snippets for suggestions ingestion [DOCS] update docs snippets for suggestions ingestion May 14, 2024
@burtenshaw
Copy link
Contributor Author

@frascuchon This assumes that we do not want to change the functionality?

@frascuchon
Copy link
Member

@frascuchon This assumes that we do not want to change the functionality?

Not for now, but I think it makes sense to support in the future label.score or label.agent to map automatically the score or agent for a suggestion. What do you think?

@@ -16,8 +16,8 @@ dataset.records.add(
{
"text": "Hello World, how are you?",
"label": "negative",
"label.response": "negative",
"label.score": 0.9,
"label.suggestion.response": "negative",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I saw this and not sure if suggestion.value instead of suggestion.response. I think we're already using .value on exports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I missed that there was a response. I've changed the example to make it clearer how it works.

@burtenshaw burtenshaw merged commit bf8d203 into main May 14, 2024
4 of 6 checks passed
@burtenshaw burtenshaw deleted the docs/update-docs-to-suggestions branch May 14, 2024 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG/DOCS] Scores and agent mapping not working
2 participants