Upgrade underlying Argo SDK #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k project Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
…alls so we avoid client-side deserialization errors for actually valid responses Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
…bination required for retries Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
…del instantiation, usages through `mock_model`, and model docs/type errors that were caught by tests Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
Signed-off-by: flaviuvadan <[email protected]>
|
I tested all the examples in an Argo cluster with version 3.2.4. Retries are fine, along with task parallelism and all currently supported features. |
flaviuvadan
added a commit
that referenced
this pull request
Jan 9, 2022
This reverts commit 9fb642b.
flaviuvadan
added a commit
that referenced
this pull request
Jan 9, 2022
flaviuvadan
added a commit
that referenced
this pull request
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles issue #7. In addition, it fixes some of the type issues that we encountered in the past with deserializing responses post workflow submission. It's also worth noting that the new underlying Argo SDK requires
limitrather thandurationandmax_durationfor retries. This introduces aget_limitin theRetryobject that computes the limit based onmax_duration // duration, which should typically correspond to the intended limit. There are some leftover TODOs that will be added as GitHub Issues after this is merged.It would be ideal to add some more tests to this prior to release but leaving it open for any watchers.