Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate word in comments #9465

Merged
merged 1 commit into from
Aug 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/argo-server-sso.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ metadata:
workflows.argoproj.io/rbac-rule-precedence: "0"
```

Now, for the the namespace that you own, configure a service account which would allow members of your team to perform operations in your namespace.
Now, for the namespace that you own, configure a service account which would allow members of your team to perform operations in your namespace.
Make sure that the precedence of the namespace service account is higher than the precedence of the login service account. Create appropriate role that you want to grant to this service account and bind it with a role-binding.

```yaml
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/workflow/v1alpha1/workflow_phase.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const (
WorkflowPending WorkflowPhase = "Pending" // pending some set-up - rarely used
WorkflowRunning WorkflowPhase = "Running" // any node has started; pods might not be running yet, the workflow maybe suspended too
WorkflowSucceeded WorkflowPhase = "Succeeded"
WorkflowFailed WorkflowPhase = "Failed" // it maybe that the the workflow was terminated
WorkflowFailed WorkflowPhase = "Failed" // it maybe that the workflow was terminated
WorkflowError WorkflowPhase = "Error"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const ObjectEditor = <T extends any>({type, value, buttons, onChange}: Pr
icon='caret-right'
outline={true}
onClick={() => {
// Attempt to move the the correct section of the document. Ideally, we'd have the line at the top of the
// Attempt to move the correct section of the document. Ideally, we'd have the line at the top of the
// editor, but Monaco editor does not have method for this (e.g. `revealLineAtTop`).

// find the line for the section in either YAML or JSON
Expand Down
2 changes: 1 addition & 1 deletion workflow/controller/dag.go
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ func (woc *wfOperationCtx) resolveDependencyReferences(dagCtx *dagContext, task
}

// findLeafTaskNames finds the names of all tasks whom no other nodes depend on.
// This list of tasks is used as the the default list of targets when dag.targets is omitted.
// This list of tasks is used as the default list of targets when dag.targets is omitted.
func (d *dagContext) findLeafTaskNames(tasks []wfv1.DAGTask) []string {
taskIsLeaf := make(map[string]bool)
for _, task := range tasks {
Expand Down