Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support packages that span multiple directories #230

Merged

Conversation

eltoder
Copy link
Contributor

@eltoder eltoder commented Mar 24, 2024

I extracted this from #228 since it is unrelated to the rest of the changes.

@eltoder eltoder force-pushed the feature/packages-multiple-paths branch from cbe5f25 to 689fcd3 Compare March 24, 2024 14:09
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd1b80c) to head (06f2683).

❗ Current head 06f2683 differs from pull request most recent head 462dc95. Consider uploading reports for the commit 462dc95 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          509       506    -3     
  Branches       106       106           
=========================================
- Hits           509       506    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariebovenberg
Copy link
Owner

@eltoder excellent work. After you rebase this branch, I can get to merging it.

@ariebovenberg
Copy link
Owner

ariebovenberg commented Mar 25, 2024

let's see what the 'update branch' button does

...ah...a merge 😒

let's see if I can undo this while not screwing everything up...

@ariebovenberg ariebovenberg force-pushed the feature/packages-multiple-paths branch from 17d5993 to 06f2683 Compare March 25, 2024 19:54
@eltoder eltoder force-pushed the feature/packages-multiple-paths branch from 06f2683 to 462dc95 Compare March 25, 2024 19:55
@ariebovenberg
Copy link
Owner

👀 did we just both rebase and force push? Anyways it looks like the commits are in order in the end 😄

Copy link
Owner

@ariebovenberg ariebovenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eltoder
Copy link
Contributor Author

eltoder commented Mar 25, 2024

@ariebovenberg looks like we did :)

@ariebovenberg
Copy link
Owner

@eltoder any other related features you have planned? If not, I'll bundle your improvements into a new release

@ariebovenberg ariebovenberg merged commit 3884ca7 into ariebovenberg:main Mar 25, 2024
9 checks passed
@eltoder eltoder deleted the feature/packages-multiple-paths branch March 25, 2024 20:00
@eltoder
Copy link
Contributor Author

eltoder commented Mar 25, 2024

@ariebovenberg That's it for now. Thank you for merging!

@ariebovenberg
Copy link
Owner

@eltoder thanks for your contribution 🤝

@ariebovenberg
Copy link
Owner

ariebovenberg commented Mar 25, 2024

Release 0.19.0 is out now with the improved functionality 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants