Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark std rand #129

Merged
merged 11 commits into from
Dec 16, 2020
Merged

Ark std rand #129

merged 11 commits into from
Dec 16, 2020

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Dec 12, 2020

Description

Moves ark-ff::UniformRand to be a re-export of ark-std's version. Deprecates ark-ff::test_rng().

closes: #113

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests - n/a
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon
Copy link
Member Author

That second commit shows that the deprecation is working as intended!

CHANGELOG.md Outdated Show resolved Hide resolved
@Pratyush
Copy link
Member

Pratyush commented Dec 12, 2020

Hmm unfortunately due to how we handle warnings, this change will cause downstream crates to fail to compile (because we #[deny(deprecated)])

@ValarDragon
Copy link
Member Author

ValarDragon commented Dec 12, 2020

Hrmm, its only our repos that deny deprecated, perhaps other downstream users keep it at warn?
(Also perhaps we should change from deny(deprecated) to warn(deprecated) anyway?)

(I'll update this repo for the change though)

@Pratyush Pratyush merged commit 4003962 into master Dec 16, 2020
@Pratyush Pratyush deleted the ark_std_rand branch December 16, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor rand from ff to its own crate
2 participants