Use zmq_die in poll_one
#22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would provide user code with more information about errors.
vrurg
added a commit
to vrurg/cro-zeromq
that referenced
this pull request
Mar 7, 2021
Since `poll_one` is a blocking call, when service is stopped it throws with `X::AdHoc` due to -1 returned by `zmq_poll`. Unfortunately, `poll_one` doesn't use `zmq_die` and therefore there is no way to determine if the error is caused by socket closing or not. For this reason this PR relies on `$closer` value to find out if the exception must be rethrows or dropped. PR arnsholt/Net-ZMQ#22 is submitted to replace plain `die` with `zmq_die`. But until then this PR should be ok get things straighten out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would provide user code with more information about errors.