Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage UI #20

Merged
merged 14 commits into from
Dec 28, 2023
Merged

Homepage UI #20

merged 14 commits into from
Dec 28, 2023

Conversation

Albert-2
Copy link

hey @arpitghura
i have done changes and it looks good but you can improve it further
Thanks You...!!
Happie Coding....!:)

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notes-jar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 4:09pm

@arpitghura
Copy link
Owner

Hey @Albert-2 I know I took time to review the PR but I got busy. This PR has some serious issues which includes edit, and delete functionality, saving and reading notes to & from local storage.

There will be popup issues which are triggering on CRUD operation. Also, Add new note button will be of no use.

@arpitghura
Copy link
Owner

If you want to work on this PR even after CodePeak, I can merge this in a feature branch and give partial points. You can continue working on these issues to fix them.

@Albert-2
Copy link
Author

hey @arpitghura
i am ok with partial points
and will continue to work on this issue after codepeak'23

@arpitghura arpitghura changed the base branch from main to 2-home-page-design December 28, 2023 17:11
@arpitghura arpitghura merged commit 5a6ef6e into arpitghura:2-home-page-design Dec 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants