Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceProvider canProvide() should also accept Qualifiers as arguments. #123

Open
iocanel opened this issue Feb 10, 2017 · 1 comment
Open

Comments

@iocanel
Copy link

iocanel commented Feb 10, 2017

Currently arquillian only checks type inside canProvide and ignores qualifiers. This is really limiting as we can have multiple resource providers per type.

For example inside arquillian-cube the StandaloneCubeUrlResourceProvider is only meant to handle URLs annotated with @DockerUrl, but its canProvide() will return true for all URLs. This prevents me from creating and using something like a @KubernetesUrl.

So, I think that ideally we should have a more accurate canProvide or we should iterate over all resource providers until we get one that canProvde a non-null result.

@bartoszmajsak
Copy link
Member

I was thinking about the same lately, but for this we would need to pass "injection point", not the type itself. Requires quite a bit of work, but definitely helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants