Workaround failure in bench_cg. Evaluate x array early #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanky
approved these changes
Dec 26, 2018
examples/benchmarks/bench_cg.py
Outdated
| @@ -137,11 +138,11 @@ def timeit(calc, iters, args): | |||
|
|
|||
| def test(): | |||
| print("\nTesting benchmark functions...") | |||
| A, b, x0 = setup_input(50) # dense A | |||
| A, b, x0 = setup_input(50, 7) # dense A | |||
There was a problem hiding this comment.
If you are going to add a new param explicitly, can you change this to be named parameters ? i.e. setup_input(n=50, sparsity=7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bench_cg test was failing to execute on the CUDA backend because two non-linear JIT nodes were being combined and caused the resulting kernel parameter size to go above the threshold. The nodes did not cross the evaluation threshold before hand. This will need to be address upstream.
Upstream issue: arrayfire/arrayfire#2389