Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffprobekit does not recognise non-ascii characters #192

Closed
theli opened this issue Oct 18, 2021 · 5 comments
Closed

ffprobekit does not recognise non-ascii characters #192

theli opened this issue Oct 18, 2021 · 5 comments
Assignees
Labels
apple Affect Apple platforms bug Something isn't working fixed-in-v4.5.1 library Affects the library v4.4 Affects v4.4 release v4.5 Affects v4.5 release

Comments

@theli
Copy link

theli commented Oct 18, 2021

Description
Audio mp3 files with id3v2 tags filled in Chinese or Japanese in UTF are returned garbled when using ffprobekit method FFprobeKit.getMediaInformationAsync and latest 4.5 version for iOS. I have tried obtaining metadata with getLogs() and got same problem. Running ffprobe on MacOS returns valid tags metadata.
Expected behavior
Tags written in unicode non-ascii characters should be extracted properly.

Environment

  • Platform: iOS
  • Architecture: any
  • Version 4.5
  • Source branch (if applicable) [e.g. master, development, v4.4]
  • Xcode version 12.4, 13
  • Cocoapods version 4.5

Other
Add any other context about the problem here.

@tanersener
Copy link
Collaborator

Can you provide a sample file to reproduce this issue?

@theli
Copy link
Author

theli commented Oct 19, 2021

try to ffprobe this url https://filedn.eu/lDgxtlj7H6nBDflef6kzNq7/tmp/03_jp_sample.mp3
Note, that I have tried ffprobe-kit on iOS only with remote url and got the issue. I am also attaching the file here.
03_jp_sample.zip
.

@tanersener tanersener added apple Affect Apple platforms library Affects the library needs-analysis We don't know that this is. It must be investigated further v4.4 Affects v4.4 release v4.5 Affects v4.5 release labels Oct 19, 2021
@tanersener
Copy link
Collaborator

Thanks. I managed to see the problem locally. Though I'm not sure about the reason yet.

In FFmpegKitConfig.m we are using NSUTF8StringEncoding to convert the strings from char* to NSString. I suspect those Unicode characters are lost during that conversion. We need to debug this.

@tanersener tanersener self-assigned this Oct 21, 2021
@tanersener tanersener added bug Something isn't working fixed-on-development Fixed on the development branch. Not released yet. and removed needs-analysis We don't know that this is. It must be investigated further labels Oct 21, 2021
@tanersener
Copy link
Collaborator

Fixed on the development branch.

@tanersener
Copy link
Collaborator

The fix is released in v4.5.1.

@tanersener tanersener added fixed-in-v4.5.1 and removed fixed-on-development Fixed on the development branch. Not released yet. labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple Affect Apple platforms bug Something isn't working fixed-in-v4.5.1 library Affects the library v4.4 Affects v4.4 release v4.5 Affects v4.5 release
Projects
None yet
Development

No branches or pull requests

2 participants