Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix require.resolve issue for Node 12 #3

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix require.resolve issue for Node 12 #3

merged 1 commit into from
Dec 9, 2019

Conversation

spencerfdavis
Copy link
Contributor

Issue here in Node 12 - nodejs/node#27583

In attempting to upgrade the lambda docker image to Node 12, it failed to load the src/lambda/index file based in because of a change in require.resolve as documented in the issue above. This fix works still with Node 8+

flintinatux
flintinatux approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@flintinatux flintinatux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

@spencerfdavis
Copy link
Contributor Author

@spencerfdavis spencerfdavis merged commit e908a47 into master Dec 9, 2019
@spencerfdavis spencerfdavis deleted the fix-require-resolve-node-12 branch December 9, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flintinatux flintinatux flintinatux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerfdavis @flintinatux