feat: ignore price database #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordkiz
reviewed
Nov 1, 2021
Comment on lines
-40
to
-41
| "NOT *L2FydGljbGVz*", | ||
| "NOT *L2FydGljbGUv*", |
There was a problem hiding this comment.
@MounirDhahri This PR removes these two entries completely. Is that intended?
There was a problem hiding this comment.
I also noticed that. These two has been deleted after I ran yarn build
lordkiz
approved these changes
Nov 1, 2021
|
🚀 PR was released in |
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the big diff, I alphabetically sorted the paths to make it easier to add new ones in the future.
This PR resolves https://artsyproduct.atlassian.net/browse/CX-2113
Description:
The goal of this PR is to make sure that the price-database link does not open the app and instead opens the link in the browser
Note:
The next steps here would be updating artsy-eigen-web-association in artsy-wwwify and force