Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add myCollectionMarketSignals module #331

Merged
merged 1 commit into from
Jun 2, 2022
Merged

add myCollectionMarketSignals module #331

merged 1 commit into from
Jun 2, 2022

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Jun 2, 2022 •
edited by jira bot
Loading

The type of this PR is: TYPE

This PR resolves CX-2610

Description

Add myCollectionMarketSignals module

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@dariakoko dariakoko self-assigned this Jun 2, 2022
@artsy-peril artsy-peril bot added Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features labels Jun 2, 2022
@dariakoko dariakoko merged commit 0ae9373 into main Jun 2, 2022
@dariakoko dariakoko deleted the dariakoko/CX-2610/add-new-type_ branch June 2, 2022 17:30
@artsyit
Copy link
Collaborator

artsyit commented Jun 2, 2022

🚀 PR was released in v4.49.0 🚀

@dariakoko dariakoko removed the request for review from MounirDhahri June 2, 2022 17:43
@damassi
Copy link
Member

damassi commented Jun 2, 2022

Hi @dariakoko - please have a look at this RFC about how to name PRs and commits!

@dariakoko
Copy link
Contributor Author

Hi @damassi okay, thanks for the link!
And sorry for the spam

@damassi
Copy link
Member

damassi commented Jun 2, 2022

all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dariakoko dariakoko

Labels
Jira Synced Indicates that Peril has connected this PR to Jira released Version: Minor A deploy for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dariakoko @artsyit @damassi