feat: warn against squashing #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is 🍏 at long last. 😅 |
dblandin
reviewed
Aug 11, 2023
app/services/deploy_service.rb
Outdated
| @@ -61,7 +61,7 @@ def create_pull_request | |||
| deploy_strategy.arguments['base'], | |||
| deploy_strategy.arguments['head'], | |||
| 'Deploy', | |||
| 'This is an automatically generated release PR!' | |||
| "This is an automatically generated release PR!\n\nHumans: remember to _merge_ (not squash) this PR." | |||
There was a problem hiding this comment.
Should we update this to "(not squash or rebase)"? I believe we run into the same problem with rebase-merged deploy PRs.
There was a problem hiding this comment.
I didn't realize that--sure!
joeyAghion
force-pushed
the
joeyAghion/squash
branch
from
70acae7
to
219eda7
Compare
|
Gonna merge 🙇 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in artsy/README#516 (comment).