Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getManualOptions to be a function #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

soerface
Copy link

@soerface soerface commented Apr 2, 2015

I would like to fetch the options on my own, but with the current implementation of getManualOptions, the object must be resolved before the directive is loaded. I thought that it would be good to fetch the object in the view, but doing this does not allow me to create the getManualOptions variable before loading the directive. Therefore, I thought it would be useful to allow getManualOptions to be a function, fetching the options when needed. If there is another way doing it without changing this code, I would also be happy about hearing about it.

@Serhioromano, you implemented the getManualOptions feature like it is now, how did you resolved the object before the directive beeing loaded?

This makes it possible to provide a function in the scope which fetches the options object when needed.
@Serhioromano
Copy link
Contributor

Hmmm, let's see, .... Actually I do not know 😄

I did not need to make sure it is resolved before. All I wanted the way to pass manual options. And then everything just worked out for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants