Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some new configuration options #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joelturnbull
Copy link

I used your directive to replace an old backbone video uploader in our app, but we had some specific needs that I thought I'd submit as new configuration options. I have each of these new options split out as a separate branch if you prefer them that way. Thanks!

  1. We needed to tweak the UI a bit so I added the ability to set the templateUrl to file outside of the project.
  2. For whatever reason, our s3 is setup to forbid requests having the Content-Type header so I added an option to suppress adding that.
  3. Last, we save our files using the original filename so we can display that to the user who uploaded them. Added the ability to preserve and save the file using the original filename.

asafdav and others added 3 commits July 23, 2015 13:52
* external templates
* using original filename
* suppressing Content-Type header
@asafdav
Copy link
Owner

asafdav commented Aug 8, 2015

Hi @joelturnbull,
Thank you for this pull request, I want to merge it.
I'm about to merge #55 that already tackles your first item so after I merge it, I'll take another look at your pull request and see how to combine it.

Thanks again !

@joelturnbull
Copy link
Author

Great! Thanks @asafdav

@steverob
Copy link

@joelturnbull @asafdav would love to see the originalFileName option feature being merged.

Is there anyway to achieve that with the current version btw?

Thanks! ❤️

@asafdav
Copy link
Owner

asafdav commented Dec 1, 2015

Hi @steverob, thanks for the reminder. I merged #55 today, I will try to find some time and go over this pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants