Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced default set method before overriding with Mutators's one #24

Merged
merged 2 commits into from
Oct 10, 2013

Conversation

prdn
Copy link

@prdn prdn commented Aug 2, 2013

Hello,

Mutator's set method is generating this issue in my project: default Backbone's change event is not triggering correctly when Model.fetch overwrites model data with new values from network.
I've tested my fix on a complex environment and it is not causing any issue.

Thank you

asciidisco added a commit that referenced this pull request Oct 10, 2013
Forced default set method before overriding with Mutators's one
@asciidisco asciidisco merged commit ca2dc6c into asciidisco:master Oct 10, 2013
@asciidisco
Copy link
Owner

Hey, sorry that it took so long to get this in :(
Unfortunately I recently changed jobs & now I have less to no time to take care of this little task anymore.
If anyone is interested in helping out, please ping me, I would love to add you as a maintainer & give you the rights to publish new versions to npm.

@prdn
Copy link
Author

prdn commented Oct 12, 2013

Hi Sebastian,

thank you. I'm glad to contribute to your project.
I'm using it in a complex environment so I can keep it under control :-)

Paolo

On 10 October 2013 18:42, Sebastian Golasch [email protected]:

Hey, sorry that it took so long to get this in :(
Unfortunately I recently changed jobs & now I have less to no time to take
care of this little task anymore.
If anyone is interested in helping out, please ping me, I would love to
add you as a maintainer & give you the rights to publish new versions to
npm.


Reply to this email directly or view it on GitHubhttps://pull/24#issuecomment-26069968
.

Paolo Ardoino

@cluebcke
Copy link
Collaborator

Hi Sebastian, Paolo

I'm using Backbone.Mutators in a production webapp--it's been great and I'd be happy to help out as well, if any extra hands are needed.

On Saturday, October 12, 2013 2:34 AM, Paolo Ardoino [email protected] wrote:

Hi Sebastian,

thank you. I'm glad to contribute to your project.
I'm using it in a complex environment so I can keep it under control :-)

Paolo

On 10 October 2013 18:42, Sebastian Golasch [email protected]:

Hey, sorry that it took so long to get this in :(
Unfortunately I recently changed jobs & now I have less to no time to take
care of this little task anymore.
If anyone is interested in helping out, please ping me, I would love to
add you as a maintainer & give you the rights to publish new versions to
npm.


Reply to this email directly or view it on GitHubhttps://pull/24#issuecomment-26069968
.

Paolo Ardoino

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants