Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporters::LoggerReporter should not modify the global logger #76

Open
dhruvCW opened this issue Oct 7, 2022 · 0 comments · May be fixed by #77
Open

Reporters::LoggerReporter should not modify the global logger #76

dhruvCW opened this issue Oct 7, 2022 · 0 comments · May be fixed by #77

Comments

@dhruvCW
Copy link

dhruvCW commented Oct 7, 2022

in Reports::LoggerReporter initialization it stores the original reference to the logger that is passed in instead of cloning the object. Thus if a custom formatter is provided as parameter this formatter is also applied to the global logger which is an undesirable behaviour.

@dhruvCW dhruvCW linked a pull request Oct 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant