Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header value misinterpreted as query param #41

Open
veegee opened this issue Dec 13, 2015 · 1 comment
Open

Header value misinterpreted as query param #41

veegee opened this issue Dec 13, 2015 · 1 comment

Comments

@veegee
Copy link

veegee commented Dec 13, 2015

When specifying a header option whose value ends with an =, bat incorrectly interprets that as a query param, even when escaped.

➜ bat GET :8001/v1/me/entity 'X-APIKey:asdfasdfa\='
GET /v1/me/entity?X-APIKey%3Aasdfasdfa%5C= HTTP/1.1
Host: localhost:8001
Accept: application/json
Accept-Encoding: gzip, deflate
User-Agent: bat/0.1.0
@ghost ghost mentioned this issue Mar 31, 2016
@ghost
Copy link

ghost commented Mar 31, 2016

unfortunately this pr breaks queries with ":" into headers. I cannot think of away to fixes this without completely changing the parsing 😩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant