Run interpreter discovery under -I
mode
#2552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you have a file
typing.py
in the current working directory,python -m
doesn't work in some Python versions:This did not cause problems for us on Python 3.11 or later, because we set
PYTHONSAFEPATH
, which avoids adding the current working directory tosys.path
. However, on earlier versions, we were failing with the above. (It's important that we run interpreter discovery in the current working directory, since doing otherwise breaks pyenv shims.)The fix implemented here uses
-I
to run Python in isolated mode, which is even stricter. The downside of isolated mode is that we currently rely on settingPYTHONPATH
to find the "fake module" that we create on disk, and-I
meansPYTHONPATH
is totally ignored. So, instead, we run a script directly, and that script injects the path we care about intoPYTHONSAFEPATH
.Closes #2547.