Use available versions to simplify unsat error reports #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/simplify-pubgrub-report
branch
from
136a57f
to
5ce943a
Compare
|
With astral-sh/pubgrub#12 this does not degrade error messages anymore. |
|
Ready for review but the PubGrub changes should be merged first. Additionally, we don't have a test case that's changed by this :) that is my next priority. |
|
Request me as a reviewer if ready :) |
konstin
approved these changes
Dec 11, 2023
Comment on lines
+83
to
+89
| #[error("{package} {version} depends on itself")] | ||
| SelfDependency { | ||
| /// Package whose dependencies we want. | ||
| package: Box<PubGrubPackage>, | ||
| /// Version of the package for which we want the dependencies. | ||
| version: Box<PubGrubVersion>, | ||
| }, |
There was a problem hiding this comment.
I know that is an error type in pubgrub, but fwiw we don't consider this an error (it's surprisingly popular in python packaging)
There was a problem hiding this comment.
Great it'd probably be good to remove it then
zanieb
force-pushed
the
zb/simplify-pubgrub-report
branch
from
582b42b
to
f060641
Compare
Fix PubGrub commit
zanieb
force-pushed
the
zb/simplify-pubgrub-report
branch
from
f060641
to
2a841c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses pubgrub-rs/pubgrub#156 to consolidate version ranges in error reports using the actual available versions for each package.
Alternative to astral-sh/pubgrub#8 which implements this behavior as a method in the
Reporter— here it's implemented in our custom report formatter (#521) instead which requires no upstream changes.Requires astral-sh/pubgrub#11 to only retrieve the versions for packages that will be used in the report.
This is a work in progress. Some things to do:
We may want to allow lazy retrieval of the version maps from the formatterWe can probably do something smarter than creating vectors to hold the versionsresolveinstead ofsolveif feasible