Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep508_rs doc test #963

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix pep508_rs doc test #963

merged 1 commit into from
Jan 18, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Jan 18, 2024

Since nextest does not run doctests, this did not show up on CI.

@BurntSushi
Copy link
Member

Hmmm I don't think this --features all-tests does the same thing as --all-features. I think you'd need to add an all-tests feature to every crate duplicating all of the feature names in that crate (sans any debug features).

Since nextest does not run doctests, this did not show up
@konstin konstin changed the title Use a dedicated all-tests features instead of all-features Fix pep508_rs doc test Jan 18, 2024
@konstin
Copy link
Member Author

konstin commented Jan 18, 2024

I've trimmed this down to only fix the pep508_rs doc test

@konstin konstin enabled auto-merge (squash) January 18, 2024 14:23
@konstin konstin merged commit 7acde5a into main Jan 18, 2024
3 checks passed
@konstin konstin deleted the konsti/test-features branch January 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants