Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update K8s documentation/examples #534

Closed
1 task
tatiana opened this issue Sep 14, 2023 · 1 comment · Fixed by #554
Closed
1 task

Update K8s documentation/examples #534

tatiana opened this issue Sep 14, 2023 · 1 comment · Fixed by #554
Labels
area:docs Relating to documentation, changes, fixes, improvement good first issue Good for newcomers
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented Sep 14, 2023

The user Slack user xi-chen.qi reported in the #airflow-dbt channel that the K8s docs are outdated for the latest versions of Cosmos (1.0 and more recent):
https://apache-airflow.slack.com/archives/C059CC42E9W/p1694661534628809

Probably referring to this:
https:/astronomer/astronomer-cosmos/blob/main/docs/getting_started/kubernetes.rst

Acceptance criteria

  • K8s docs are representative of how to run the latest version of Cosmos
@tatiana tatiana added the good first issue Good for newcomers label Sep 14, 2023
@tatiana tatiana added this to the 1.1.2 milestone Sep 14, 2023
tatiana added a commit that referenced this issue Sep 27, 2023
Fix behaviour when using `ExecutionMode.KUBERNETES`, broken between the
Cosmos releases 1.0.0 and 1.1.1.

Update the documentation to be representative of the 1.x Cosmos
interface:

https://astronomer.github.io/astronomer-cosmos/getting_started/kubernetes.html

Add unit tests to avoid regressions on these fixes.

Part of the documentation fixes are made in:
astronomer/cosmos-example#4

As a next step, we must ensure integration tests for running Cosmos on
K8s to avoid this breaking change moving forward (issue #535).

Closes: #493
Closes: #548
Closes: #534

Co-authored-by: Pádraic Slattery <[email protected]>
tatiana added a commit that referenced this issue Sep 27, 2023
Fix behaviour when using `ExecutionMode.KUBERNETES`, broken between the
Cosmos releases 1.0.0 and 1.1.1.

Update the documentation to be representative of the 1.x Cosmos
interface:

https://astronomer.github.io/astronomer-cosmos/getting_started/kubernetes.html

Add unit tests to avoid regressions on these fixes.

Part of the documentation fixes are made in:
astronomer/cosmos-example#4

As a next step, we must ensure integration tests for running Cosmos on
K8s to avoid this breaking change moving forward (issue #535).

Closes: #493
Closes: #548
Closes: #534

Co-authored-by: Pádraic Slattery <[email protected]>
@tatiana
Copy link
Collaborator Author

tatiana commented Sep 27, 2023

@tatiana tatiana added area:docs Relating to documentation, changes, fixes, improvement and removed documentation labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant