Extend Cosmos custom selector to support + when using paths and tags #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated GraphSelector to take into account path and tag dbt selector methods update SelectorConfig to use regex to parse selection statement to handle graph and path statements
dosubot
bot
added
the
size:M
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dosubot
bot
added
area:selector
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
dosubot
bot
added
size:L
combine added tests into single parameterized test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 96.53% 96.53% -0.01%
==========================================
Files 64 64
Lines 3374 3402 +28
==========================================
+ Hits 3257 3284 +27
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
tatiana
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Hi @mvictoria, this is looking great, thank you for covering these use-cases that were not previously covered in Cosmos' custom selector.
Please, could you update the description adding also:
Closes: #823
Also, could we rename this PR to something more representative, such as:
"Extend Cosmos custom selector to support + when using paths and tags"
I left some minor comments inline, would love to hear your thoughts on those. Depending on how quickly we iterate on this, we may be able to release it in Cosmos 1.6.0, planned for this week.
tatiana
reviewed
Aug 14, 2024
tatiana
reviewed
Aug 14, 2024
added tests covering config
mvictoria
changed the title
update GraphSelector doc string to include selectors
|
Hey @tatiana - thanks for the review, I've updated tests for coverage and finished adding ability to use the "config" dbt selector with graph operators. Please let me know if you have any more feedback! |
tatiana
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks a lot for the contribution, @mvictoria , we'll release this change as part of Cosmos 1.6.
Merged
pankajkoti
added a commit
that referenced
this pull request
Aug 20, 2024
New Features * Add support for loading manifest from cloud stores using Airflow Object Storage by @pankajkoti in #1109 * Cache ``package-lock.yml`` file by @pankajastro in #1086 * Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana in #1079 * Add support to store and fetch ``dbt ls`` cache in remote stores by @pankajkoti in #1147 * Add default source nodes rendering by @arojasb3 in #1107 * Add Teradata ``ProfileMapping`` by @sc250072 in #1077 Enhancements * Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091 * Use ``dbt ls`` as the default parser when ``profile_config`` is provided by @pankajastro in #1101 * Add task owner to dbt operators by @wornjs in #1082 * Extend Cosmos custom selector to support + when using paths and tags by @mvictoria in #1150 * Simplify logging by @dwreeves in #1108 Bug fixes * Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in #1088 * Fix empty tag in case of custom parser by @pankajastro in #1100 * Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use ``ProjectConfig.dbt_vars`` by @tatiana in #1114 * Fix import handling by lazy loading hooks introduced in PR #1109 by @dwreeves in #1132 * Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by @pankajastro in #1162 Docs * Fix typo in azure-container-instance docs by @pankajastro in #1106 * Use Airflow trademark as it has been registered by @pankajastro in #1105 Others * Run some example DAGs in Kubernetes execution mode in CI by @pankajastro in #1127 * Install requirements.txt by default during dev env spin up by @@CorsettiS in #1099 * Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111 * Disable test for Airflow-2.5 and Python-3.11 combination in CI by @pankajastro in #1124 * Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154, #1167 --------- Co-authored-by: Pankaj Koti <[email protected]> Co-authored-by: Pankaj Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #1141 where dbt projects loaded with DBT_MANIFEST were unable to parse using the GraphSelector.
Changes:
ToDo:
add tests covering changeenable config dbt selector methodRelated Issue(s)
closes #1141
closes #823
Breaking Change? No
Checklist