Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code in BigQueryHookAsync #624

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

phanikumv
Copy link
Collaborator

@phanikumv phanikumv commented Sep 7, 2022

This PR addresses the code changes needed to use the OSS BigQueryHook within the repo instead of using a vendored hook

  • Remove _BigQueryHook usage
  • Change the tests accordingly for the google async hooks and operators

Closes: #52

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #624 (864897d) into main (a96d071) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   98.24%   98.26%   +0.01%     
==========================================
  Files          73       73              
  Lines        3994     3969      -25     
==========================================
- Hits         3924     3900      -24     
+ Misses         70       69       -1     
Impacted Files Coverage Δ
...omer/providers/google/cloud/extractors/bigquery.py 100.00% <100.00%> (ø)
...stronomer/providers/google/cloud/hooks/bigquery.py 100.00% <100.00%> (+0.79%) ⬆️
...nomer/providers/google/cloud/operators/bigquery.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍🏽

@phanikumv phanikumv merged commit 781903a into main Sep 7, 2022
@phanikumv phanikumv deleted the remove_redundant_bq_code branch September 7, 2022 14:40
@phanikumv phanikumv mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change BigQueryInsertJobOperatorAsync to use OSS BigQueryHook
2 participants