Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc string for DatabricksSubmitRunOperatorAsync and DatabricksRunNowOperatorAsync #718

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

bharanidharan14
Copy link
Contributor

@bharanidharan14 bharanidharan14 commented Oct 20, 2022

Add Doc string for the Databricks async operators
Screenshot 2022-10-20 at 11 41 48 AM

Screenshot 2022-10-20 at 11 42 02 AM

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 98.41% // Head: 98.41% // No change to project coverage 👍

Coverage data is based on head (99cf60d) compared to base (ac977f8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          85       85           
  Lines        4409     4409           
=======================================
  Hits         4339     4339           
  Misses         70       70           
Impacted Files Coverage Δ
...nomer/providers/databricks/operators/databricks.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bharanidharan14 bharanidharan14 merged commit 765033d into main Oct 20, 2022
@bharanidharan14 bharanidharan14 deleted the add-databricks-doc branch October 20, 2022 08:01
Submits a Spark job run to Databricks using the
`api/2.1/jobs/runs/submit
<https://docs.databricks.com/dev-tools/api/latest/jobs.html#operation/JobsRunsSubmit>`_
API endpoint. Using DatabricksHook It makes two non-async API calls to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital letter I coming in the middle of the sentence. Please correct it.

"Using DatabricksHook It makes two non-async API calls to"

`api/2.1/jobs/runs/submit
<https://docs.databricks.com/dev-tools/api/latest/jobs.html#operation/JobsRunsSubmit>`_
API endpoint. Using DatabricksHook It makes two non-async API calls to
submit the run, and retrieve the run page URL. By getting the job id from the response polls for the status
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesnt make sense without a comma.

"By getting the job id from the response polls for the status execute the Databricks trigger"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants