Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set auto commit to true by default in SnowflakeOperatorAsync #766

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

bharanidharan14
Copy link
Contributor

@bharanidharan14 bharanidharan14 commented Nov 18, 2022

There was an issue SnowflakeOperatorAsync with the auto-commit option which was set to false by default in SQLExecuteQueryOperator the latest apache-airflow-providers-snowflake==4.0.0rc1 was inherited from the SQLExecuteQueryOperator so now it is set to True by default in SnowflakeOperatorAsync

fixes part of #768

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 98.50% // Head: 98.50% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (995b6c1) compared to base (8c2ccfd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #766   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          86       86           
  Lines        4682     4683    +1     
=======================================
+ Hits         4612     4613    +1     
  Misses         70       70           
Impacted Files Coverage Δ
...ronomer/providers/snowflake/operators/snowflake.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phanikumv phanikumv changed the title Set auto commit to true by default Set auto commit to true by default in SnowflakeOperatorAsync Nov 18, 2022
@phanikumv phanikumv merged commit 2bd8fb3 into main Nov 18, 2022
@phanikumv phanikumv deleted the bug-fix-autocommit branch November 18, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants