Squad reader #535
Squad reader #535
Conversation
qinzzz
force-pushed
the
qinxin_dev
branch
3 times, most recently
from
bbdaccb
to
4e2d3d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 79.60% 79.73% +0.13%
==========================================
Files 224 226 +2
Lines 16006 16119 +113
==========================================
+ Hits 12741 12852 +111
- Misses 3265 3267 +2
Continue to review full report at Codecov.
|
|
the doc build failed, one word is considered as misspelling: https:/asyml/forte/pull/535/checks?check_run_id=3884346346#step:6:143 If those are not misspelled words, consider adding them to https:/asyml/forte/blob/master/docs/spelling_wordlist.txt |
ft/onto/base_ontology.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class MRCAnswer(Annotation): |
There was a problem hiding this comment.
I found that we previously use Phrase instead of a specific type to represent the answer: https:/asyml/forte-wrappers/blob/main/src/huggingface/fortex/huggingface/question_and_answering_multi.py#L19
There was a problem hiding this comment.
Sure, maybe I can delete MRCAnswer and just use Phrase?
There was a problem hiding this comment.
yeah, since I find there's no additional features introduced by MRCAnswer
forte/datasets/mrc/squad_reader.py
Outdated
| pack.set_text(text) | ||
|
|
||
| Document(pack, 0, context_end) | ||
| passage = Passage(pack, 0, len(pack.text)) |
There was a problem hiding this comment.
Looks like you are using Document for the reading part, and Passage for the whole data pack (including questions)?
The meaning of Passage is supposed to be the former (the reading material). And maybe we can use Document to cover the whole datapack
|
|
||
| Returns: QA pairs and the context of a paragraph of a passage in SQuAD dataset. | ||
| """ | ||
| with open(file_path, "r", encoding="utf8", errors="ignore") as file: |
There was a problem hiding this comment.
are there other things like question id? those could be useful when doing an evaluation.
There was a problem hiding this comment.
Add question ID to MRC question
There was a problem hiding this comment.
couldn't see the id in this PR, did you push the changes?
This PR adds a new dataset: squadv2.0. Fix #537
Description of changes
Add a new reader for the SQuAD dataset in datasets/mrc; add corresponding ontologies.
Possible influences of this PR.
Resued ontology
Passagein race_qaTest Conducted
Test squad reader