Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Key Removal in Configs #554

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

Pushkar-Bhuse
Copy link
Collaborator

Description of changes

Removal of the type parameter in configs of data augmentation processors.

Possible influences of this PR.

This PR will help reduce confusion regarding the type="" that appeared in DA processors until now.

Test Conducted

Tested the working of these changes on all DA methods that inherited the base_data_augment_processor.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #554 (247a30d) into master (169718e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files         227      227           
  Lines       16155    16155           
=======================================
  Hits        12888    12888           
  Misses       3267     3267           
Impacted Files Coverage Δ
...ocessors/data_augment/algorithms/eda_processors.py 97.43% <ø> (ø)
...ata_augment/algorithms/word_splitting_processor.py 93.33% <ø> (ø)
...rs/base/data_augment_replacement_processor_test.py 99.43% <ø> (ø)
...rithms/embedding_similarity_replacement_op_test.py 98.11% <ø> (ø)
...ugment/algorithms/word_splitting_processor_test.py 96.49% <ø> (ø)
...essors/data_augment/base_data_augment_processor.py 99.19% <100.00%> (ø)
...ment/algorithms/back_translation_augmenter_test.py 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169718e...247a30d. Read the comment docs.

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM, thanks for this!

@hunterhector hunterhector merged commit 7104c01 into asyml:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants