Add ontologies for audio data #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added static methods to infer pack type * added unit tests for datapack type inference. * fixed issue#558 * fixed black: forte/data/selector.py * fixed import-outside-toplevel * WIP: waiting for ndarray supported * Ndarray -> ndarray * values -> value * added ndarray to SUPPORTED_PRIMITIVES * WIP: generator accepts NdArray attribute * remove breakpoints * fixed None -> "None" * WIP: designing NdArrayProperty * WIP: ndarray_size -> ndarray_shape * fixed lint * fixed lint * added ndarray property test cases * removed irrelevant onto spec * fixed lint * fixed lint * fixed black * fixed description * added FNdArray, a wrapper class for NdArray metric * handle None dtype * removed Optional typing * fixed description * added unit tests for ndarray attribute * fixed black * added doc string and more tests * fixed type * added reference to np.ndarray * added unit tests for ndarray attribute against dtype, shape, and warning Co-authored-by: Zhanyuan Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 80.07% 80.32% +0.24%
==========================================
Files 234 235 +1
Lines 16538 16748 +210
==========================================
+ Hits 13243 13452 +209
- Misses 3295 3296 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
There are a few things we could follow up with this:
- Add a few test cases related to the newly updated condition branches, notice that test cases should cover most of these branches since bugs often happen in these less used branches. Check the codecov report if needed. Examples of not tested areas include the warning message, deleting
AudioAnnotation, and other similar new conditional branches.
The other two items should have their own issues and tickets, could you create two issues based on them?
- We have generally covered the
getfunction but haven't covered theget_datafunction. The differences between these two functions:getobtain the classes whileget_datareturn them as primitive types and nested dict.get_dataalso can handle m more complex requests. It is worth creating an issue regarding this. Basically, we should have theget_datafunction also work but not simply raising NotImplementedError as Line935 in data_pack.py. - The
indexandbuild_coverage_indexfunctions should be polished to include AudioAnnotation as well. Related line is here:Line 1101 in 7adecba
| require_annotations(AudioAnnotation) | ||
| and isinstance(range_annotation, Annotation) | ||
| ): | ||
| logger.warning( |
There was a problem hiding this comment.
Is this conditional branch (i.e. the warning branch) tested?
hunterhector
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #591 .
Description of changes
New top level entry: AudioAnnotation
textproperty withaudio.New ontologies in base_ontology: Recording, AudioAnnotation
Test Conducted
A unit test
audio_annotation_testis added to test all the new ontologies added.