Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import statements repaired for some examples #624

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

Piyush13y
Copy link
Collaborator

@Piyush13y Piyush13y commented Feb 4, 2022

This PR fixes #623

Description of changes

Import statements for packages like forte.huggingface, forte.elastic, etc were repaired
eg,
import forte.hugginface changed to import forte.huggingface
import forte.elastic changed to import forte.elastic

Possible influences of this PR.

Should allow executing some of our examples without throwing ModuleNotFoundError

@Piyush13y Piyush13y marked this pull request as ready for review February 4, 2022 05:48
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes, we forget to update the examples after that refactoring.

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #624 (f83619f) into master (6ceaf01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   80.75%   80.75%           
=======================================
  Files         240      240           
  Lines       17055    17055           
=======================================
  Hits        13772    13772           
  Misses       3283     3283           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ceaf01...f83619f. Read the comment docs.

@hunterhector hunterhector merged commit 38cf119 into asyml:master Feb 4, 2022
qinzzz pushed a commit to qinzzz/forte that referenced this pull request Feb 8, 2022
* import statemeents repaired

* repaired most import statements from forte.package to fortex.package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some modules imported incorrectly in examples
2 participants