Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization #680

Merged
merged 61 commits into from
May 26, 2022
Merged

Serialization #680

merged 61 commits into from
May 26, 2022

Conversation

wanglec
Copy link
Collaborator

@wanglec wanglec commented Mar 12, 2022

This PR fixes #679.

Description of changes

Add set_state, get_state, serialize and deserialize functions in data_store.py and base_store.py

Possible influences of this PR.

We could serialize data_store objects.

Test Conducted

Tests are conducted in tests/forte/data/data_store_serialization_test.py

@wanglec wanglec requested a review from qinzzz March 12, 2022 01:31
@wanglec wanglec changed the title Skeleton Serialization Mar 12, 2022
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #680 (0841d5d) into master (181d293) will increase coverage by 0.11%.
The diff coverage is 95.51%.

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   81.20%   81.31%   +0.11%     
==========================================
  Files         249      250       +1     
  Lines       18914    19067     +153     
==========================================
+ Hits        15359    15505     +146     
- Misses       3555     3562       +7     
Impacted Files Coverage Δ
tests/forte/data/data_store_test.py 95.04% <ø> (ø)
forte/data/base_store.py 76.11% <88.46%> (+5.66%) ⬆️
forte/data/data_store.py 91.53% <95.94%> (+0.87%) ⬆️
tests/forte/data/data_store_serialization_test.py 98.21% <98.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181d293...0841d5d. Read the comment docs.

forte/data/base_store.py Outdated Show resolved Hide resolved
forte/data/base_store.py Show resolved Hide resolved
forte/data/base_store.py Show resolved Hide resolved
forte/data/base_store.py Outdated Show resolved Hide resolved
forte/data/base_store.py Outdated Show resolved Hide resolved
forte/data/data_store.py Outdated Show resolved Hide resolved
forte/data/data_store.py Outdated Show resolved Hide resolved
tests/forte/data/data_store_serialization_test.py Outdated Show resolved Hide resolved
tests/forte/data/data_store_serialization_test.py Outdated Show resolved Hide resolved
@mylibrar mylibrar added this to the 0.3 alpha milestone May 20, 2022
@hunterhector
Copy link
Member

@mylibrar can you also take a look at this PR?

forte/data/data_store.py Outdated Show resolved Hide resolved
forte/data/data_store.py Outdated Show resolved Hide resolved
forte/data/data_store.py Show resolved Hide resolved
forte/data/data_store.py Show resolved Hide resolved
forte/data/data_store.py Outdated Show resolved Hide resolved
forte/data/data_store.py Show resolved Hide resolved
@hunterhector
Copy link
Member

hunterhector commented May 25, 2022 via email

@mylibrar mylibrar merged commit f9f5daa into master May 26, 2022
@wanglec wanglec deleted the skeleton branch May 27, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data_store serialization
5 participants