-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization #680
Merged
Serialization #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 81.20% 81.31% +0.11%
==========================================
Files 249 250 +1
Lines 18914 19067 +153
==========================================
+ Hits 15359 15505 +146
- Misses 3555 3562 +7
Continue to review full report at Codecov.
|
qinzzz
reviewed
Mar 12, 2022
@mylibrar can you also take a look at this PR? |
Should it start from 0 instead of 1?
…On Wed, May 25, 2022 at 1:58 PM wanglec ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In forte/data/data_store.py
<#680 (comment)>:
> + self.__elements[k] = SortedList(self.__elements[k])
+ for e in self.__elements[k]:
+ if e is not None:
+ if self._is_annotation(k):
+ # annotation-like
+ self._DataStore__tid_ref_dict[
+ e[constants.TID_INDEX]
+ ] = e
+ else:
+ # non-annotation-like
+ # use `reset_index` to recalculate indices
+ type_name = e[constants.ENTRY_TYPE_INDEX]
+ if type_name in reset_index:
+ reset_index[type_name] += 1
+ else:
+ reset_index[type_name] = 1
1. Yes I will add more docs.
2. Yes it is a counter of type. Since I am recreating the
__tid_idx_dict, I need to know how many entries of a type already
exist to assign the correct index.
3. Yes it should be tid.
—
Reply to this email directly, view it on GitHub
<#680 (comment)>, or
unsubscribe
<https:/notifications/unsubscribe-auth/AAHYBN27LTXN64H2V5ZFFE3VLZS3FANCNFSM5QRFFGOA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Hector, Liu Zhengzhong
Website: https://hunterhector.github.io/
LinkedIn: http://www.linkedin.com/pub/hector-zhengzhong-liu/23/115/406
|
mylibrar
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #679.
Description of changes
Add
set_state
,get_state
,serialize
anddeserialize
functions in data_store.py and base_store.pyPossible influences of this PR.
We could serialize data_store objects.
Test Conducted
Tests are conducted in
tests/forte/data/data_store_serialization_test.py