Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add num_gdrive_retries to maybe_download() #695

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

mylibrar
Copy link
Collaborator

Description of changes

Add num_gdrive_retries to maybe_download() to specify the number of retries of download requests to Google Drive

@mylibrar mylibrar self-assigned this Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #695 (aef70d6) into master (343e8c0) will increase coverage by 0.09%.
The diff coverage is 98.94%.

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   80.86%   80.95%   +0.09%     
==========================================
  Files         242      242              
  Lines       17809    17900      +91     
==========================================
+ Hits        14401    14491      +90     
- Misses       3408     3409       +1     
Impacted Files Coverage Δ
tests/forte/data/data_utils_test.py 94.11% <90.00%> (-1.89%) ⬇️
forte/data/data_utils.py 75.22% <100.00%> (+1.88%) ⬆️
forte/pipeline.py 93.93% <100.00%> (+0.21%) ⬆️
tests/forte/pipeline_test.py 97.22% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636a7f8...aef70d6. Read the comment docs.

@hunterhector hunterhector merged commit 77fb73c into asyml:master Mar 24, 2022
@mylibrar mylibrar deleted the download_issue branch March 24, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants