fix delete entries #782
Merged
fix delete entries #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 80.94% 81.00% +0.06%
==========================================
Files 249 249
Lines 18664 18702 +38
==========================================
+ Hits 15108 15150 +42
+ Misses 3556 3552 -4
Continue to review full report at Codecov.
|
wanglec
requested review from
hepengfe,
mylibrar and
hunterhector
and removed request for
hepengfe
hunterhector
approved these changes
May 18, 2022
mylibrar
pushed a commit
to mylibrar/forte
that referenced
this pull request
May 18, 2022
* fix delete entries * add return statements * fix return values * fix magic numbers and add none counter * fix docstring and separate entry_dict Co-authored-by: wanglechuan-gif <[email protected]> Co-authored-by: Hector <[email protected]>
mylibrar
pushed a commit
to mylibrar/forte
that referenced
this pull request
May 18, 2022
* fix delete entries * add return statements * fix return values * fix magic numbers and add none counter * fix docstring and separate entry_dict Co-authored-by: wanglechuan-gif <[email protected]> Co-authored-by: Hector <[email protected]>
hunterhector
added a commit
that referenced
this pull request
May 19, 2022
* Fix some issues in ontology doc * redirect pipeline example in pipeline README.md due to invalid hyperl… (#791) * redirect pipeline example in pipeline README.md due to invalid hyperlinks for ner models * remove --use-feature=in-tree-build as this option is removed and it's enabled by default by pip * fix delete entries (#782) * fix delete entries * add return statements * fix return values * fix magic numbers and add none counter * fix docstring and separate entry_dict Co-authored-by: wanglechuan-gif <[email protected]> Co-authored-by: Hector <[email protected]> Co-authored-by: Suqi Sun <[email protected]> Co-authored-by: feipenghe <[email protected]> Co-authored-by: wanglec <[email protected]> Co-authored-by: wanglechuan-gif <[email protected]> Co-authored-by: Hector <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #780.
Description of changes
Drop the
index_idfield in the content of non-annotation-like entries. Instead, add it in theentry_dict. If a non-annotation-like entry is deleted, put aNoneplaceholder in that place to maintain the index correctly.Getiterator andnextorprevwill skip the placeholder.Possible influences of this PR.
May affect how to calculate the number of entries.
Test Conducted
Delete is tested with next/prev/get functions