Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt EmbeddingSimilarityReplacementOp to SingleAnnotationAugmentOp #784

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

abbeyyyy
Copy link
Collaborator

This PR fixes #783.

Description of changes

Adapt EmbeddingSimilarityReplacementOp to SingleAnnotationAugmentOp

Possible influences of this PR.

This PR re-implements EmbeddingSimilarityReplacementOp as a SingleAnnotationAugmentOp

Test Conducted

Test cases included in embedding_similarity_replacement_op_test.py

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #784 (c2f3e04) into master (f8fe32b) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   80.50%   80.50%           
=======================================
  Files         252      252           
  Lines       19360    19363    +3     
=======================================
+ Hits        15585    15588    +3     
  Misses       3775     3775           
Impacted Files Coverage Δ
.../algorithms/embedding_similarity_replacement_op.py 90.62% <81.81%> (+0.96%) ⬆️
...rithms/embedding_similarity_replacement_op_test.py 98.11% <100.00%> (ø)
...essors/data_augment/base_data_augment_processor.py 98.38% <0.00%> (-0.81%) ⬇️
...orte/processors/data_augment/data_aug_processor.py 96.59% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fe32b...c2f3e04. Read the comment docs.

@abbeyyyy abbeyyyy marked this pull request as ready for review May 10, 2022 19:09
@hunterhector hunterhector merged commit 9e56f3e into asyml:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt EmbeddingSimilarityReplacementOp to SingleAnnotationAugmentOp
3 participants