Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a wrong call in the script #861

Merged
merged 9 commits into from
Jul 7, 2022
Merged

Conversation

hunterhector
Copy link
Member

@hunterhector hunterhector commented Jul 6, 2022

This PR fixes #860.

Description of changes

  1. Correct the function call, with named parameters
  2. Correct the corresponding tutorial/readme files
  3. Update some warning messages since we find that namespace_depth probably won't work when the target directory exists.

Possible influences of this PR.

This change should be quite local.

Test Conducted

We have test cases in the OntologyGenerator class, but no tests for the command line scripts now.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #861 (44dc157) into master (62b081a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage   80.74%   80.75%   +0.01%     
==========================================
  Files         254      254              
  Lines       19364    19364              
==========================================
+ Hits        15635    15637       +2     
+ Misses       3729     3727       -2     
Impacted Files Coverage Δ
forte/data/ontology/ontology_code_generator.py 90.09% <ø> (ø)
...orte/data/ontology/ontology_code_generator_test.py 100.00% <ø> (ø)
forte/command_line/generate_ontology/__main__.py 23.61% <100.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b081a...44dc157. Read the comment docs.

@hunterhector hunterhector merged commit 8e03abe into asyml:master Jul 7, 2022
@hunterhector hunterhector deleted the generate branch July 7, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect call to the generator from forte cmd scripts
2 participants