Replace rental with ouroboros #44
Conversation
rental is not maintained any more and users are encouraged to switch to alternatives.
|
@est31 curious that we've had a similar idea, of going through rental's reverse dependencies and migrating them. I guess because self_cell is quite new you didn't know about it? It is more limited than ouroboros but has some nice advantages eg. scpwiki/wikijump#270 so that imo it's a better fit for many current users of rental and ouroboros |
|
@Voultapher good point about the less dependencies. IDK what the maintainers prefer. Lol indeed I'm going through the reverse dependencies. I was mainly motivated by the forward compat warning. Note that beyond the projects on crates.io, there is also a lot of direct use of rental. Even if the reverse dependencies are all migrated there will still be many projects using it. Maybe grep.app can help with finding those projects. |
|
Yes I've been thinking about grep.app too, but more along the lines of trying to find handwritten unsafe self referential code like it's suggested tokio does here https://internals.rust-lang.org/t/improving-self-referential-structs/4808/75, where often it's probably unsound in some way. Having implemented |
|
Sorry if we are sidetracking this issue, feel free to shoot me an email [email protected] I'd like to coordinate our effort out of band. |
| @@ -139,8 +139,8 @@ impl<R: Read + Write + Unpin> ImapStream<R> { | |||
| }); | |||
| match res { | |||
| Ok(response) => Ok(Some(response)), | |||
| Err(rental::RentalError(err, block)) => { | |||
| self.buffer.return_block(block); | |||
| Err((err, heads)) => { | |||
There was a problem hiding this comment.
@Voultapher returning the owner seems to be missing from self_cell
There was a problem hiding this comment.
This is a bit out of context. I suspect you are looking into using self_cell instead of ouroboros and some feature is missing. Please elaborate.
There was a problem hiding this comment.
Yes, in this case with self_cell you would just get err back, not block/heads
Looking at the source it seems like self_cell just drops everything inside the cell when an error occurs
rental is not maintained any more and users
are encouraged to switch to alternatives.