Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

x-eventgateway-dial-mapping properties: comma string vs object properties #56

Open
boyney123 opened this issue Oct 5, 2021 · 2 comments
Labels
keep-open keep-open

Comments

@boyney123
Copy link

Hey,

I noticed in the examples I have seen the x-eventgateway-dial-mapping value is a comma seperated string with values example: 0.0.0.0:20473,event-gateway-demo.asyncapi.org:20473.

Coming at this new, I'm not really sure what these values mean, I know they are consumed by the gateway, but maybe it's best if we could be explicit to what they mean?

Proposal:

...
x-eventgateway-dial-mapping:
	proxyPort: 0.0.0.0:20473
	target: event-gateway-demo.asyncapi.org:20473
...

Ignore the property names, but hopefully, you get the idea, maybe we could describe them?

Thoughts @smoya ?

@smoya
Copy link
Collaborator

smoya commented Oct 6, 2021

Hey @boyney123!

I'm totally +1 to change those pipe-separated values to become objects. I also think this will improve user experience.
Btw, x-eventgateway-dial-mapping is badly used right now and I'm working on a refactor around the configuration which hopefully will clarify as well some topics.

I'm gonna leave this issue open because still the replacement of pipe-separated values is a thing to do.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 4, 2022
@smoya smoya added the keep-open keep-open label Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
keep-open keep-open
Projects
None yet
Development

No branches or pull requests

3 participants