Skip to content

Commit

Permalink
fix: upload release assets not working (#1440)
Browse files Browse the repository at this point in the history
  • Loading branch information
Amzani authored May 22, 2024
1 parent 50d9fb1 commit 428057d
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/upload-release-assets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
name: Generate and upload assets
if: startsWith(github.event.commits[0].message, 'chore(release):')
runs-on: ${{ matrix.os }}
continue-on-error: true
strategy:
matrix:
include:
Expand All @@ -23,11 +24,11 @@ jobs:
npm_script: pack:tarballs
dist_folder: tar
extension: tar.gz
- os: windows-latest
- os: ubuntu-latest
npm_script: pack:windows
dist_folder: win32
extension: x64.exe
- os: windows-latest
- os: ubuntu-latest
npm_script: pack:windows
dist_folder: win32
extension: x86.exe
Expand Down Expand Up @@ -57,6 +58,10 @@ jobs:
const packageJson = require('./package.json');
const packageJsonVersion = packageJson.version;
core.setOutput('version', packageJsonVersion);
- if: matrix.npm_script == 'pack:windows':
#fix for windows build issue #1433
name: Install p7zip-full nsis
run: sudo apt-get install -y p7zip-full nsis
- if: steps.lockversion.outputs.version == '18' && matrix.os == 'windows-latest'
#npm cli 10 is buggy because of some cache issue
name: Install npm cli 8
Expand Down

0 comments on commit 428057d

Please sign in to comment.