Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added openapi conversion support #1500

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Aug 18, 2024

Description

In convert command added support for converting openapi to asyncapi and also introduced a -p flag for perspective for this conversion

image

Related issue(s)
#1498

@Gmin2 Gmin2 changed the title feat: Added openapi conversion support feat: added openapi conversion support Aug 18, 2024
@Gmin2
Copy link
Contributor Author

Gmin2 commented Aug 18, 2024

This can only be merged when asyncapi/converterjs#284 is merged

@Shurtu-gal
Copy link
Collaborator

@Gmin2 could you check the issue with tests?

@Gmin2
Copy link
Contributor Author

Gmin2 commented Sep 18, 2024

@Gmin2 could you check the issue with tests?

Done @Shurtu-gal just need to wait for asyncapi/converter-js#280 to be merged
image

@Shurtu-gal
Copy link
Collaborator

/u

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Gmin2
Copy link
Contributor Author

Gmin2 commented Sep 23, 2024

can we get this merged @Shurtu-gal , as it is blocking #1516

@Shurtu-gal Shurtu-gal merged commit e204457 into asyncapi:master Sep 23, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants