Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/node to package.json #783

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Sep 4, 2023

Description

The current project generated with asyncapi new glee is not working because it's missing the @types/node dependency. I'm adding it.

Related issue(s)
No issue

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Now working fine when executing the Glee project once created 👍

@derberg derberg changed the title fix: adds @types/node to package.json fix: add @types/node to package.json Sep 6, 2023
@derberg
Copy link
Member

derberg commented Sep 6, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c31ceab into asyncapi:master Sep 6, 2023
23 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.54.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants