Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in contributing file #796

Merged
merged 2 commits into from
Jul 14, 2023
Merged

docs: fix typo in contributing file #796

merged 2 commits into from
Jul 14, 2023

Conversation

depleur
Copy link
Contributor

@depleur depleur commented Jul 10, 2023

Description

Fixed a typo in CONTRIBUTING.md. See Related issue(s) for more.

Related issue(s)

Issue #795

github-actions[bot]
github-actions bot reviewed Jul 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@depleur depleur changed the title Update CONTRIBUTING.md style: Update CONTRIBUTING.md Jul 10, 2023
@depleur depleur changed the title style: Update CONTRIBUTING.md style: update CONTRIBUTING.md Jul 10, 2023
AnimeshKumar923
AnimeshKumar923 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnimeshKumar923
Copy link
Contributor

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @AnimeshKumar923! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@depleur
Copy link
Contributor Author

depleur commented Jul 14, 2023

Hey, I've updated the branch so it can be merged now.

@thulieblack
Copy link
Member

thulieblack commented Jul 14, 2023 •
edited
Loading

hey @AnimeshKumar923 you can't merge this yet as you need approvals from Code Owners

@thulieblack thulieblack changed the title style: update CONTRIBUTING.md docs: fix typo in contributing file Jul 14, 2023
@AnimeshKumar923
Copy link
Contributor

/rtm

@asyncapi-bot asyncapi-bot merged commit 7f82479 into asyncapi:master Jul 14, 2023
12 checks passed
@AnimeshKumar923
Copy link
Contributor

AnimeshKumar923 commented Jul 14, 2023 •
edited
Loading

hey @AnimeshKumar923 you can't merge this yet as you need approvals from Code Owners

Thank you for the information.

  • Just saw that anyone can add the ready-to-merge label after a confirmation that the change is doing well.

  • Can it be done like adding the ready-to-merge label and then approving changes from your side so that it merges as soon as you approve it?

@AnimeshKumar923 AnimeshKumar923 mentioned this pull request Jul 14, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@thulieblack thulieblack thulieblack approved these changes

@AnimeshKumar923 AnimeshKumar923 AnimeshKumar923 approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@depleur @AnimeshKumar923 @asyncapi-bot @thulieblack