Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header sizing #177

Merged
merged 4 commits into from
Sep 15, 2023
Merged

fix: header sizing #177

merged 4 commits into from
Sep 15, 2023

Conversation

SoNiC-HeRE
Copy link
Contributor

@SoNiC-HeRE SoNiC-HeRE commented Aug 29, 2023

Description

Decided to stick with the last layout as it appears more clean but if required, I'd change it as suggested

Related issue(s)
Fixes #175

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 65027f4
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/64f7ad823e67b00008f5a1aa
😎 Deploy Preview https://deploy-preview-177--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@SoNiC-HeRE SoNiC-HeRE changed the title Fix header sizing fix: header sizing Aug 29, 2023
@SoNiC-HeRE
Copy link
Contributor Author

@Mayaleeeee please let me know if any changes are required

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Thank you @SoNiC-HeRE

cc @thulieblack @AceTheCreator @derberg

@AceTheCreator
Copy link
Member

@SoNiC-HeRE can you update the branch with the latest changes from master

@SoNiC-HeRE
Copy link
Contributor Author

@SoNiC-HeRE can you update the branch with the latest changes from master

sure

@SoNiC-HeRE
Copy link
Contributor Author

@AceTheCreator please let me know if any more changes are required

@AceTheCreator
Copy link
Member

@AceTheCreator please let me know if any more changes are required

Noticed the heading size stays the same despite the screen size. I believe is should be smaller on mobile screen size. cc @Mayaleeeee

@Mayaleeeee
Copy link
Member

@AceTheCreator please let me know if any more changes are required

Noticed the heading size stays the same despite the screen size. I believe is should be smaller on mobile screen size. cc @Mayaleeeee

Yeah, I just noticed that too, thanks @AceTheCreator

@SoNiC-HeRE, please use 32px for the text, 38px for line height and -2% for letter spacing for the header size on mobile.
Screenshot 2023-09-04 215311

This is how the mobile version looks like
Home-Mobile

@SoNiC-HeRE
Copy link
Contributor Author

SoNiC-HeRE commented Sep 5, 2023

  • Before:

image

  • After:

mobile

@AceTheCreator @Mayaleeeee let me know if more changes are required

@AceTheCreator
Copy link
Member

LGTM! @Mayaleeeee wyt?

@Mayaleeeee
Copy link
Member

LGTM! @Mayaleeeee wyt?

Awesome 🤗🤗

@AceTheCreator AceTheCreator merged commit a9aeb37 into asyncapi:master Sep 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the font size used for the header on the Conference Website.
3 participants