Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get ticket button added #186

Merged
merged 10 commits into from
Sep 15, 2023
Merged

Conversation

vishvamsinh28
Copy link
Contributor

@vishvamsinh28 vishvamsinh28 commented Sep 4, 2023

added button on venue page to buy ticket

Screenshot 2023-09-04 at 9 54 00 PM

fixes #185

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 0bb2fc1
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6504104671d12e00088e1f29
😎 Deploy Preview https://deploy-preview-186--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AceTheCreator
Copy link
Member

@vishvamsinh28 I don't see an issue opened for this pr; we're also following the design provided by @Mayaleeeee

@Mayaleeeee wyt?

@vishvamsinh28
Copy link
Contributor Author

@AceTheCreator I have opened issue for this #186 . And @derberg wanted button for buying tickets on the venue page also

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Sep 5, 2023

@vishvamsinh28 I don't see an issue opened for this pr; we're also following the design provided by @Mayaleeeee

@Mayaleeeee wyt?

It makes sense, @AceTheCreator. The button has to be there because we want to make it easy for our users to buy tickets for each location without returning to the main landing page. So, a big thank you to @derberg and @vishvamsinh28 for their contribution.

@vishvamsinh28, let me explain how it's supposed to work. We need to remove the ''Agenda, Speakers, and Event & Host Sponsor'' button.

Please watch the video below for a visual reference on how it should look and how the button should interact.
screen-recording (2).webm and here's the Figma file.

Madrid_Location

@vishvamsinh28
Copy link
Contributor Author

@Mayaleeeee @AceTheCreator removed buttons and updated design of ticket button

@AceTheCreator
Copy link
Member

@Mayaleeeee WYT?

@thulieblack
Copy link
Member

@vishvamsinh28, please could you add another Free Tickets Form button on the London page.

here's the link 👉🏿 https://forms.gle/c7t8k2JABcF26guq5

thank you so much

@Mayaleeeee
Copy link
Member

@Mayaleeeee WYT?

Let's use our pry colour as suggested by @thulieblack.
Thanks for your contribution, @vishvamsinh28
Screenshot 2023-09-06 214735

@Mayaleeeee
Copy link
Member

@AceTheCreator Is the distance between the location and date intentional? I would like to know before creating issues on it.

Screenshot 2023-09-06 215040

@thulieblack
Copy link
Member

thulieblack commented Sep 7, 2023

@vishvamsinh28, you made a mistake on the London Page.

There need to be two buttons:

  1. Get your Tickets ➡️ https://opencollective.com/asyncapi/events/asyncapi-conference-on-tour-6b3c0aa1/contribute/aacot-london-edition-61313
  2. Free Tickets Form ➡️ https://forms.gle/c7t8k2JABcF26guq5

@vishvamsinh28
Copy link
Contributor Author

@thulieblack buttons and links are updated

"ticket": "https://opencollective.com/asyncapi/events/asyncapi-conference-on-tour-6b3c0aa1/contribute/aacot-london-edition-61313",
"freeTicket":"https://docs.google.com/forms/d/e/1FAIpQLSdKxKvHGqmCmFJ7ldJJcAJNnmuie057vYrEh219gCXRDMZU5g/viewform",
"buttonText":"Get your Tickets",
"freeTicketTxt":"Tickets Form"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"freeTicketTxt":"Tickets Form"
"freeTicketTxt":"Free Tickets Form"

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Sep 7, 2023

Hey @thulieblack
We can't have the two buttonss like this
Screenshots_2023-09-07-13-48-08.png

  1. And what's the difference between "Get your. Tickets" and the "Ticket Form"

  2. How long is the "tickets form" button going to be there?

cc @AceTheCreator

@thulieblack
Copy link
Member

@Mayaleeeee, it is correct the way it is. We have two different buttons for 2 different tickets

We have a paid ticket option and a free ticket option that's why the form is there

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Sep 7, 2023

@Mayaleeeee, it is correct the way it is. We have two different buttons for 2 different tickets

We have a paid ticket option and a free ticket option that's why the form is there

@thulieblack
We can't have two primary buttons sitting very close to each other on the interface because it's confusing and distracting.

Primary buttons are used to represent the most important action on a page, so what I am saying in essence is that, one has to be a pry button, and the other a secondary.

We need to prioritize the one we want our users to click on, then that would be our pry button.

Also, if the ticket form is for free tickets, then I suggest we change it to free tickets, because the ticket form sounds confusing. @thulieblack

@thulieblack
Copy link
Member

@Mayaleeeee, do you have suggestions on what we should do because they both need to be there on the page?

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Sep 7, 2023

@Mayaleeeee, do you have suggestions on what we should do because they both need to be there on the page?

Yeah, I do. @thulieblack

Which one is our main priority?
Get Your Tickets or Ticket Form?

If it's the first one, then that would be our primary button, and the second would be a secondary.

@thulieblack
Copy link
Member

thulieblack commented Sep 7, 2023

Prioritize Get your Tickets following Free Tickets Form

@vishvamsinh28
Copy link
Contributor Author

@Mayaleeeee How it should look on the website ?

@Mayaleeeee
Copy link
Member

@Mayaleeeee How it should look on the website ?

I'm gonna design that, and show you.

Thank you @thulieblack @vishvamsinh28

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Sep 8, 2023

@Mayaleeeee, do you have suggestions on what we should do because they both need to be there on the page?

@thulieblack, So here are my suggestions

  1. The button below is the secondary button design. However, it may not be evident to users. I want to be sure it's not just from my side, so please let me know your thoughts on its visibility.
    1

  2. We can make the "Ticket Form'' a white fill; that would be perfect for visibility.
    Also, I suggest we change the name of the "Tickets Form" to "Grab Free Tickets" to clarify that users can obtain a free ticket by filling out the form. The current name gives the impression that users need to acquire a ticket (from the Get your Tickets button) or complete a form to get a paid or free ticket (from the Ticket Form button).
    By using clear and concise language, we can provide better instructions to users and ensure they understand what is expected of them.

In essence, I am saying that if the "Ticket Form" button is for free tickets, then let it be explicitly mentioned to avoid confusion and misunderstandings.

2 (2)

cc @AceTheCreator

@thulieblack
Copy link
Member

Hey Maya, I like the design; let's go ahead with it.

@vishvamsinh28 These changes only apply to the London page only. The Madrid page is fine as it is. You can also change the button description to "Grab Free Tickets" as Maya suggests.

The form will be visible on the website until the 17th of September so it is only for a week that it needs to be there.

Thanks

@thulieblack
Copy link
Member

Hey @vishvamsinh28 do not add the free ticket button anymore . Just remove it whenever you get a chance and lets get it merged

@vishvamsinh28
Copy link
Contributor Author

@thulieblack we can merge this pr now i have made changes

@thulieblack
Copy link
Member

hey @vishvamsinh28 we're almost there a few things

  1. Update your branch with the latest commits
  2. Return the Free Tickets Form to the Madrid page. We are only making changes to the London Page.

Let me know if I can clear up any confusion or need any help

@thulieblack
Copy link
Member

Thanks so much @AceTheCreator please merge this

@AceTheCreator AceTheCreator merged commit 8ccd225 into asyncapi:master Sep 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add get tickets in venue page
4 participants