Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle past events #289

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

monoMonu
Copy link

Description

  • added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file.
    I tested the code by changing the date of one of the events as you can see...because there were only upcoming events.

  • removed the "apply to be a speaker" button from the past events as it has no use there.

Screenshot 2024-03-23 232443
Screenshot 2024-03-23 232726
Screenshot 2024-03-23 232754

Related issue(s)
Resolves #208

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a322906
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6709698d046bc500086154b8
😎 Deploy Preview https://deploy-preview-289--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@monoMonu monoMonu changed the title feat: Handle past events feat: handle past events Mar 23, 2024
@Mayaleeeee
Copy link
Member

Mayaleeeee commented Apr 8, 2024

Description

  • added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file.
    I tested the code by changing the date of one of the events as you can see...because there were only upcoming events.
  • removed the "apply to be a speaker" button from the past events as it has no use there.

Screenshot 2024-03-23 232443 Screenshot 2024-03-23 232726 Screenshot 2024-03-23 232754

Related issue(s) Resolves #208

@monoMonu, I can't find the design you did. Can you please share the link or a screenshot? Also, the screenshot you provided can't be viewed from my side.

@AceTheCreator
Copy link
Member

@monoMonu any update on this?

@monoMonu
Copy link
Author

Description

  • added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file.
    I tested the code by changing the date of one of the events as you can see...because there were only upcoming events.
  • removed the "apply to be a speaker" button from the past events as it has no use there.

Screenshot 2024-03-23 232443 Screenshot 2024-03-23 232726 Screenshot 2024-03-23 232754
Related issue(s) Resolves #208

@monoMonu, I can't find the design you did. Can you please share the link or a screenshot? Also, the screenshot you provided can't be viewed from my side.

@Mayaleeeee @AceTheCreator
Here are the screenshots, you can review

Screenshot 2024-03-23 232443
Screenshot 2024-03-23 232726
Screenshot 2024-03-23 232754

@thulieblack
Copy link
Member

@monoMonu please resolve the conflicts

@monoMonu
Copy link
Author

monoMonu commented Jun 5, 2024

@monoMonu please resolve the conflicts

Done

@AceTheCreator
Copy link
Member

@monoMonu can you please resolve the conflicts in this pr so we can move forward?

@monoMonu
Copy link
Author

monoMonu commented Jun 25, 2024

@monoMonu can you please resolve the conflicts in this pr so we can move forward?

I have resolved the conflict, please move forward

@AceTheCreator
Copy link
Member

@monoMonu can you please resolve the conflicts in this pr so we can move forward?

I have resolved the conflict, please move forward

@monoMonu, I'd suggest you remove the upcoming text. we should only focus on ended

@monoMonu
Copy link
Author

monoMonu commented Jul 8, 2024

@monoMonu, I'd suggest you remove the upcoming text. we should only focus on ended

I have removed 'upcoming' text

@AceTheCreator
Copy link
Member

@monoMonu, I'd suggest you remove the upcoming text. we should only focus on ended

I have removed 'upcoming' text

@monoMonu i noticed there's an hypen- in the upcoming events. Can you get rid of it?

@thulieblack
Copy link
Member

@monoMonu could you please add the final changes to the PR

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the texts on the ended event cards are not visible @monoMonu

@monoMonu
Copy link
Author

monoMonu commented Aug 28, 2024

@Mayaleeeee @AceTheCreator @thulieblack
I have removed the hyphen and also resolved text visibility issue for all cards.
image

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly resolve your merge conflict

@ashmit-coder
Copy link
Contributor

cc: @monoMonu

@monoMonu
Copy link
Author

Kindly resolve your merge conflict

Done, please merge it

@thulieblack
Copy link
Member

@monoMonu please resolve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

would be nice if venue from past events is grayed out
7 participants