Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button content #360

Closed
wants to merge 2 commits into from
Closed

Conversation

souvikjs01
Copy link

Description

  1. remove red squiggles.
  2. center the button content for better visualization.
  3. make the dropdown content dynamic.

Related issue(s)
Resolve #345

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a90dd2
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/670621a0066fc30008fd9d85
😎 Deploy Preview https://deploy-preview-360--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@souvikjs01 souvikjs01 changed the title improve button content fix: button content Aug 22, 2024
@AceTheCreator
Copy link
Member

@souvikjs01 can you include screenshots of your changes and also resolve the merge conflict?

@ashmit-coder
Copy link
Contributor

Hey @souvikjs01 @AceTheCreator . If this pr is not moving ahead we shall close it, there is already a new pr for the same issue available.

@AceTheCreator
Copy link
Member

Hey @souvikjs01 @AceTheCreator . If this pr is not moving ahead we shall close it, there is already a new pr for the same issue available.

I agree with you @ashmit-coder

@ashmit-coder
Copy link
Contributor

Hey @AceTheCreator i guess its has been long enough to close this pr.

@souvikjs01 souvikjs01 closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <In the Dropdown section, contents are not perfectly aligned in the mobile view>
3 participants