Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add online speaker images and names #409

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

techmannih
Copy link
Contributor

Close #408
Issue #408
@thulieblack please review and merge it.
Screenshot 2024-10-02 222842

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 04516e6
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/66ffb15906886c00081f4d79
😎 Deploy Preview https://deploy-preview-409--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@techmannih techmannih changed the title Add Online Speaker Images and Names feat: Add Online Speaker Images and Names Oct 2, 2024
@techmannih techmannih changed the title feat: Add Online Speaker Images and Names feat: add Online Speaker Images and Names Oct 2, 2024
@techmannih techmannih changed the title feat: add Online Speaker Images and Names feat: add online speaker images and names Oct 2, 2024
@ashmit-coder
Copy link
Contributor

hey @techmannih could you into why some of the checks are failing?

@ashmit-coder
Copy link
Contributor

Hey @thulieblack shall we make the images available offline, one pr is dealing with that issue. If we are adding on new images I think it should follow the same convention.

@thulieblack
Copy link
Member

The pr is not complete, please add the descriptions for each.

@thulieblack
Copy link
Member

Yes @ashmit-coder it should, please give some details on how too

@ashmit-coder
Copy link
Contributor

hey @thulieblack @techmannih
#404

lets wait for this issue to get resolved at first IMO.
If this pr is urgent then lets merge it (after it passes the checks) and later we will raise a new issue to follow the local images convention.

@thulieblack
Copy link
Member

thulieblack commented Oct 2, 2024

Makes sense, the PR isn't ready yet some of the speakers info is missing that's why checks aren't passing maybe 🤔

@techmannih
Copy link
Contributor Author

@ashmit-coder @thulieblack there is no description for rest of speakers, so how will I add

@ashmit-coder
Copy link
Contributor

Lets see I am not quite sure why the checks are failing as well.

@ashmit-coder
Copy link
Contributor

@ashmit-coder @thulieblack there is no description for rest of speakers, so how will I add

I guess @thulieblack means adding the speakers from the last years session ?

@techmannih
Copy link
Contributor Author

hey @techmannih could you into why some of the checks are failing?

Lets see I am not quite sure why the checks are failing as well.

these are passed now

@ashmit-coder
Copy link
Contributor

Hey @techmannih , the titles for

  1. Atinuke Oluwabamikemi Kayode
  2. Aishat Muibudeen
  3. Ankit Dash

are missing.

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techmannih please make the changes

config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
config/speakers.json Outdated Show resolved Hide resolved
@techmannih
Copy link
Contributor Author

@ashmit-coder @thulieblack please check now

@thulieblack
Copy link
Member

@techmannih, the images are not showing

Screen.Recording.2024-10-03.102400.mp4

I suggest you download them, create a folder locally under public/img/online-conf-images/ and reference them using the following path /img/online-images/.....jpeg

@techmannih
Copy link
Contributor Author

@ashmit-coder @thulieblack please check now

@techmannih
Copy link
Contributor Author

@ashmit-coder @thulieblack

@thulieblack
Copy link
Member

Thanks, @techmannih; I'll wait for @ashmit-coder's review first.

Please be patient, reviews take time

@techmannih
Copy link
Contributor Author

@thulieblack sure, thank you!

@ashmit-coder
Copy link
Contributor

Hey @techmannih could you try to use .webp format for the images instead of jpeg . We are looking forward to reduce load times of the conference website as well and this will be a great start to it!
If you are unable to do it, just use jpeg.
Other than that the changes LGTM @thulieblack ! (Just verify the data from your end)

@techmannih
Copy link
Contributor Author

@ashmit-coder sure

@techmannih
Copy link
Contributor Author

techmannih commented Oct 4, 2024

@ashmit-coder @thulieblack please check now

@ashmit-coder
Copy link
Contributor

LGTM!

@ashmit-coder
Copy link
Contributor

Hey @thulieblack ig the PR is ready to be merged!

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @techmannih

@thulieblack
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 6cbab41 into asyncapi:master Oct 8, 2024
13 checks passed
@techmannih
Copy link
Contributor Author

@thulieblack please add Hacktoberfest-accepted label

@AceTheCreator AceTheCreator added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Oct 16, 2024
AceTheCreator added a commit that referenced this pull request Oct 16, 2024
AceTheCreator added a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Online Speaker Images
5 participants