Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating docs failes if project is a git repository. #461

Closed
Tracked by #477
Souvikns opened this issue Jun 8, 2023 · 10 comments · Fixed by #559
Closed
Tracked by #477

Generating docs failes if project is a git repository. #461

Souvikns opened this issue Jun 8, 2023 · 10 comments · Fixed by #559
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest released

Comments

@Souvikns
Copy link
Member

Souvikns commented Jun 8, 2023

Describe the bug

Generating docs is automatic in Glee, but it fails when the project is a git repository. Also, I would want to have no errors right after I create a glee project.

x "/Users/postman/Documents/Programs/Learning/greet-bot/docs" is in a git repository with unstaged changes. Please commit your changes before proceeding or add proper directory to .gitignore file. You can also use the --force-write flag to skip this rule (not recommended).
    at Generator.verifyTargetDir (/Users/postman/Documents/Programs/Learning/greet-bot/node_modules/@asyncapi/generator/lib/generator.js:846:71)
    at async Generator.generate (/Users/postman/Documents/Programs/Learning/greet-bot/node_modules/@asyncapi/generator/lib/generator.js:173:29)

How to Reproduce

To reproduce the bug make sure the project is a glee repository, and just run

npm run start

Expected behavior

It should create the docs even if my project is a Git repository, and by default I should not see any error logs when I create a new project.

@Souvikns Souvikns added the bug Something isn't working label Jun 8, 2023
@rukundob451
Copy link

@Souvikns, I have taken note of the issue when generating the documentation fails when the project is a Git repository with unstaged changes in the /Users/postman/Documents/Programs/Learning/greet-bot/docs directory and currently looking into it.

@Souvikns Souvikns changed the title Generating docs failes in a git repository. Generating docs failes if project is a git repository. Jun 9, 2023
@Souvikns Souvikns mentioned this issue Jul 13, 2023
10 tasks
@Souvikns
Copy link
Member Author

@rukundob451 do you need any help with this issue, according to the generator docs we can pass forcreWrite as true in

const generator = new Generator(

I think this flag was done so that generator does not accidentally rewrite the code, but in our case, we are generating docs which is not a problem if it is re-written.

@rukundob451
Copy link

Hey @Souvikns, yes needed some help with this!

@Souvikns
Copy link
Member Author

Let me know, how I can help you.

@Souvikns
Copy link
Member Author

Souvikns commented Oct 2, 2023

@rukundob451 are you working on this, or should I put this issue up for hacktoberfest?

@Souvikns
Copy link
Member Author

Souvikns commented Oct 4, 2023

I think no one is working on this currently so this Issue is open for hacktoberfest.

@ankur0904
Copy link
Contributor

@Souvikns I want to work on this issue.

@Souvikns
Copy link
Member Author

Souvikns commented Oct 9, 2023

sure @ankur0904 go ahead.

@freakfan15
Copy link
Contributor

hey @Souvikns, I think no one is working on this, and I understand what to do here. Can I take this up?

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants