feat: update parser-js to v2 #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Souvikns
requested review from
fmvilas,
KhudaDad414 and
asyncapi-bot-eve
as code owners
Pull Request Test Coverage Report for Build 6272543340Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
4 tasks
fmvilas
requested changes
Sep 25, 2023
fmvilas
reviewed
Sep 27, 2023
| @@ -34,7 +38,7 @@ const TEST_ASYNCAPI_DOCUMENT = new AsyncAPIDocument({ | |||
| } | |||
| }) | |||
|
|
|||
| const schema = TEST_ASYNCAPI_DOCUMENT.channel('test/channel').publish().message().payload().json() | |||
| const schema = TEST_ASYNCAPI_DOCUMENT.channels().get('test/channel')?.json().publish.message.payload | |||
There was a problem hiding this comment.
Suggested change
| const schema = TEST_ASYNCAPI_DOCUMENT.channels().get('test/channel')?.json().publish.message.payload | |
| const schema = TEST_ASYNCAPI_DOCUMENT.channels().get('test/channel').operations().filterByReceive()[0].messages().all()[0].payload() |
fmvilas
reviewed
Sep 27, 2023
fmvilas
reviewed
Sep 27, 2023
|
/au |
KhudaDad414
previously approved these changes
Oct 16, 2023
|
/rtm |
|
Kudos, SonarCloud Quality Gate passed!
|
KhudaDad414
approved these changes
Oct 20, 2023
|
/rtm |
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to upgrade parser-js to v2 to support spec 2.0
Related issue(s)
Fixes #409